fix a bug in read_in_file

CHANGELOG.md

@@ -3,3 +3,4 @@
 * added `encoding` to `read_lines`
 * added `none_if_false`
 * fixed import mishap in `satella.coding.transforms` with `hashables_to_int`
+* fixed `read_in_file` if file does not exist and default is not set

satella/__init__.py

-__version__ = '2.14.33a3'
+__version__ = '2.14.33a4'

satella/files.py

@@ -168,6 +168,7 @@ def read_in_file(path: str, encoding: tp.Optional[str] = None,
     :param default: value to return when the file does not exist. Default (None) will raise a
         FileNotFoundError
     :return: file content, either decoded as a str, or not as bytes
+    :raises FileNotFoundError: file did not exist and default was not set
     """
     if os.path.isdir(path):
         if default is not _NOTSET:
@@ -178,9 +179,9 @@ def read_in_file(path: str, encoding: tp.Optional[str] = None,
         if encoding is None:
             file = open(path, 'rb')
         else:
-            file = codecs.open(path, 'rb', encoding)
+            file = codecs.open(path, 'r', encoding)
     except FileNotFoundError:
-        if default:
+        if default is not _NOTSET:
             return default
         raise
 

tests/test_files.py

@@ -16,6 +16,9 @@ def putfile(path: str) -> None:
 
 class TestFiles(unittest.TestCase):
 
+    def test_read_nonexistent_file(self):
+        self.assertRaises(FileNotFoundError, lambda: read_in_file('moot'))
+
     def test_read_lines(self):
         lines = read_lines('LICENSE')
         self.assertTrue(all(lines))