diff --git a/satella/processes.py b/satella/processes.py index c0dfbd9f477b4caeff1db2bdacb96c2bd5b89abd..7a0b9a7887568543c50a8e17b06e8e692a11c00c 100644 --- a/satella/processes.py +++ b/satella/processes.py @@ -27,7 +27,9 @@ def call_and_return_stdout(args: tp.Union[str, tp.List[str]], Everything in kwargs will be passed to subprocess.Popen A bytes object will be returned if encoding is not defined, else stdout will be decoded - according to specified encoding + according to specified encoding. + + #todo every usage of this call will spawn a daemonic thread, pending a fix :param args: arguments to run the program with. If passed a string, it will be split on space. :param timeout: amount of seconds to wait for the process result. If process does not complete @@ -52,7 +54,6 @@ def call_and_return_stdout(args: tp.Union[str, tp.List[str]], except subprocess.TimeoutExpired: proc.kill() proc.wait() - reader_thread.join() if proc.returncode != expected_return_code: raise ProcessFailed(proc.returncode)