From 9b2d7a97af842023533bf0c57e4136b66cbb8f6d Mon Sep 17 00:00:00 2001
From: Mandar Harshe <mandarharshe@gmail.com>
Date: Mon, 8 Nov 2021 23:03:36 +0100
Subject: [PATCH] PR comment suggestions and fixes
Remove unnecessary delete
Revert deleting Close method call
---
pyproject.toml | 2 +-
rocksdb/_rocksdb.pyx | 1 +
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/pyproject.toml b/pyproject.toml
index 2bf5ec8..6d1b4c5 100644
--- a/pyproject.toml
+++ b/pyproject.toml
@@ -1,3 +1,3 @@
[build-system]
-requires = ["setuptools", "wheel", "Cython"]
+requires = ["setuptools", "wheel", "cython"]
build-backend = "setuptools.build_meta"
diff --git a/rocksdb/_rocksdb.pyx b/rocksdb/_rocksdb.pyx
index b37021a..618586e 100644
--- a/rocksdb/_rocksdb.pyx
+++ b/rocksdb/_rocksdb.pyx
@@ -1738,6 +1738,7 @@ cdef class DB(object):
copts.in_use = False
del self.cf_options[:]
with nogil:
+ st = self.db.Close()
self.db = NULL
if self.opts is not None:
self.opts.in_use = False
--
GitLab