From 79cfcfcfd9192b26ec491ff551cbd9ab8169f6c5 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Adeodato=20Sim=C3=B3?= <73768+dato@users.noreply.github.com> Date: Fri, 3 Dec 2021 11:47:58 -0300 Subject: [PATCH] Ensure Debian workflows do not download remote software (#10) Debian builds should use the packaged versions of the tools, only, which seems achievable with pip's --no-build-isolation. This commits also adds a verbose flag, to give the ability to easily verify this. --- .github/workflows/debian.yml | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/.github/workflows/debian.yml b/.github/workflows/debian.yml index 1bcd88a..67f5836 100644 --- a/.github/workflows/debian.yml +++ b/.github/workflows/debian.yml @@ -30,14 +30,14 @@ jobs: python3-dev python3-pip python3-pytest \ libsnappy-dev libbz2-dev liblz4-dev libz-dev - - name: Symlink pytest - run: | - ln -s /usr/bin/pytest-3 /usr/local/bin/pytest - - name: Build pyrocksdb + # TODO(dato): consider using pypa/build --no-isolaiton, to + # build the package using a tool specifically designed for + # that, rather than trusting it to a tool that does a lot + # more (pip). run: | - python3 -m pip install '.[test]' + python3 -m pip install --no-build-isolation -v '.[test]' - name: Run tests run: | - pytest --pyargs rocksdb + pytest-3 --pyargs rocksdb -- GitLab